Fix plotting to stop using methods/attributes removed from models #491
+32
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67535775 |
Summary: New mypy errors due to mypy update. We update to latest mypy version and now pin so we don't get more surprises. Note that the ignore in dim_grid is necessary as that is a perfectly valid use of slice (with imaginary numbers for the step value) but mypy seems to not understand that usage in numpy. Differential Revision: D67537899
…cebookresearch#491) Summary: Dim grid no longer exists in models, plotting code updated to use standalone dim_grid. Bounds are gone from models so get_lse_interval needs to separately define the bounds of the grid to sample from. Differential Revision: D67535775
JasonKChow
force-pushed
the
export-D67535775
branch
from
0ec1fff to
423180b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67535775 |
|
This pull request has been merged in 2f6ee28. |
JasonKChow
added a commit
that referenced
this pull request
Dec 20, 2024
Summary: Pull Request resolved: #491 Dim grid no longer exists in models, plotting code updated to use standalone dim_grid. Bounds are gone from models so get_lse_interval needs to separately define the bounds of the grid to sample from. Reviewed By: crasanders Differential Revision: D67535775 fbshipit-source-id: 4ffdbfff7f1911c8c5c4293499d11da02653b4c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Dim grid no longer exists in models, plotting code updated to use standalone dim_grid.
Bounds are gone from models so get_lse_interval needs to separately define the bounds of the grid to sample from.
Differential Revision: D67535775